upcoming: [M3-9225] - Add API queries for MarketplaceV2 #13255

harsh-akamai · 2026-01-08T04:06:17Z

Changes 🔄

Added queries for the following marketplace endpoints

GET /marketplace/products
GET /marketplace/products/{productId}
GET /marketplace/categories
GET /marketplace/types
POST /marketplace/referral

Scope 🚢

Upon production release, changes in this PR will be visible to:

All customers
Some customers (e.g. in Beta or Limited Availability)
No customers / Not applicable

How to test 🧪

Verification steps

Verify the queries call the right apis and keys.

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

All tests and CI checks are passing
TypeScript compilation succeeded without errors
Code passes all linting rules

pmakode-akamai

This is unrelated to this PR, but it might be worth fixing here: I noticed the factory mocks & Types don't fully match the API doc

logo_url_night_mode and its value should be updated to match logo_url_dark_mode
product_count be changed to products_count at L27 & L34

tvijay-akamai · 2026-01-08T09:32:26Z

packages/queries/src/marketplace/keys.ts

+import type { Filter, Params } from '@linode/api-v4';
+
+export const marketplaceQueries = createQueryKeys('marketplace', {
+  product: (productId: number) => ({


now the api has changed from /marketplace/products/{id} to /marketplace/products/{id}/details

tvijay-akamai · 2026-01-08T09:43:18Z

This is unrelated to this PR, but it might be worth fixing here: I noticed the factory mocks & Types don't fully match the API doc

logo_url_night_mode and its value should be updated to match logo_url_dark_mode

product_count be changed to products_count at L27 & L34

Let's verify all the fields for all the apis as per this doc: https://docs.google.com/document/d/1Iw5nUpUwtofBz5pSnr7j5jXPMBlncFVdyfzLYfnN0NI/edit?tab=t.0

tvijay-akamai · 2026-01-08T10:45:39Z

packages/queries/src/marketplace/keys.ts

+        queryKey: [filter],
+      }),
+      paginated: (params: Params = {}, filter: Filter = {}) => ({
+        queryFn: () => getMarketplaceTypes(params, filter),


It should be getMarketplacePartners, instead of getMarketplaceTypes

tvijay-akamai · 2026-01-08T10:59:13Z

packages/queries/src/marketplace/keys.ts

+      infinite: (filter: Filter = {}) => ({
+        queryFn: ({ pageParam }) =>
+          getMarketplaceProducts(
+            { page: pageParam as number, page_size: 25 },


Should page size be 25 for products api also?

Minimum size for a page is 25

packages/queries/src/marketplace/marketplace.ts

tvijay-akamai · 2026-01-08T11:03:13Z

packages/queries/src/marketplace/marketplace.ts

+  filter: Filter,
+  enabled: boolean = false,
+) => {
+  useQuery<ResourcePage<MarketplacePartner>, APIError[]>({


need to have a return statement before useQuery

packages/queries/src/marketplace/marketplace.ts

tvijay-akamai · 2026-01-08T11:07:45Z

packages/queries/src/marketplace/marketplace.ts

+  MarketplaceCategory,
+  MarketplacePartner,
+  MarketplacePartnerReferralPayload,
+  MarketplaceProduct,


Let's separate types from value imports and use import type { way instead for importing the types

tvijay-akamai · 2026-01-08T11:10:24Z

packages/queries/src/marketplace/marketplace.ts

+    placeholderData: keepPreviousData,
+  });
+};
+


There is no types defined in here like (like useMarketplaceTypesQuery, useAllMarketplaceTypesQuery, etc.). In keys we have queries defined for types api though. Hook should be added here for types.

tvijay-akamai · 2026-01-08T11:15:09Z

packages/queries/src/marketplace/marketplace.ts

+export const useMarketplaceProductsQuery = (
+  params: Params,
+  filter: Filter,
+  enabled: boolean = false,


Why are we defaulting enabled to false? it means queries won't run unless explicitly enabled.

Yes. I'd prefer to keep it this way until we have the feature flag. I'm open to changing the value if needed

I'd lean towards keeping the default as true and controlling this query by passing enabled from the consumer. That way, we only disable it when the feature flag is off, which is consistent with how we handle this in other places and is technically safer

…ub.com/harsh-akamai/manager into m3-9925-add-api-queries-to-marketplace

tvijay-akamai

@harsh-akamai This looks good to me. Thanks. Approved.

pmakode-akamai · 2026-01-09T08:17:09Z

packages/api-v4/src/marketplace/types.ts

  partner_id: number;
  product_tags?: string[];
  short_description: string;
  title_tag?: string;


Suggested change

title_tag?: string;

tile_tag?: string;

This should be tile_tag

pmakode-akamai · 2026-01-09T08:19:48Z

packages/api-v4/src/marketplace/types.ts

 }

 export interface MarketplaceCategory {
  category: string;


Suggested change

category: string;

name: string;

As per API doc, I think this should be name

pmakode-akamai · 2026-01-09T08:21:53Z

packages/api-v4/src/marketplace/types.ts

+  created_at: string;
+  created_by: string;
  id: number;
+  logo_url_dark_mode?: string;


Suggested change

logo_url_dark_mode?: string;

logo_url_dark_mode: string;

I don't this this should be an optional field

pmakode-akamai · 2026-01-09T08:29:57Z

packages/queries/src/marketplace/marketplace.ts

@@ -0,0 +1,197 @@
+import { APIError, createPartnerReferral, ResourcePage } from '@linode/api-v4';


Let's separate type imports from function imports

import { createPartnerReferral } from '@linode/api-v4'; import type { APIError, ResourcePage } from '@linode/api-v4';

pmakode-akamai · 2026-01-09T08:34:25Z

packages/queries/src/marketplace/marketplace.ts

+export const useMarketplaceProductsQuery = (
+  params: Params,
+  filter: Filter,
+  enabled: boolean = false,


I'd lean towards keeping the default as true and controlling this query by passing enabled from the consumer. That way, we only disable it when the feature flag is off, which is consistent with how we handle this in other places and is technically safer

pmakode-akamai · 2026-01-09T08:36:16Z

packages/utilities/src/factories/marketplace.ts

 export const marketplaceCategoryFactory =
  Factory.Sync.makeFactory<MarketplaceCategory>({
-    id: Factory.each((id) => id),
    category: Factory.each((id) => `marketplace-category-${id}`),


Suggested change

category: Factory.each((id) => `marketplace-category-${id}`),

name: Factory.each((id) => `marketplace-category-${id}`),

pmakode-akamai · 2026-01-09T08:38:06Z

packages/utilities/src/factories/marketplace.ts

+    product_tags: ['tag1', 'tag2'],
    short_description:
      'This is a short description of the marketplace product.',
    title_tag: 'Marketplace Product Title Tag',


Suggested change

title_tag: 'Marketplace Product Title Tag',

tile_tag: 'New',

or

Suggested change

title_tag: 'Marketplace Product Title Tag',

tile_tag: '60 days free trial',

pmakode-akamai · 2026-01-09T08:38:45Z

packages/utilities/src/factories/marketplace.ts

+    created_at: '2024-01-01T00:00:00',
+    created_by: 'user1',
    id: Factory.each((id) => id),
+    logo_url_dark_mode: 'https://www.example.com/logo-night-mode.png',


Suggested change

logo_url_dark_mode: 'https://www.example.com/logo-night-mode.png',

logo_url_dark_mode: 'https://www.example.com/logo-dark-mode.png',

minor nit

pmakode-akamai · 2026-01-09T08:46:49Z

packages/api-v4/src/marketplace/types.ts

@@ -1,42 +1,59 @@
 export interface MarketplaceProductDetail {
  documentation: string;


Suggested change

documentation: string;

documentation?: string;

documentation appears to be an optional field as well

pmakode-akamai · 2026-01-09T08:50:00Z

packages/api-v4/src/marketplace/types.ts

  category_ids: number[];
+  created_at: string;
+  created_by: string;
  details?: MarketplaceProductDetail;


Not a blocker, but I don't see details marked as optional anywhere. Still it's worth checking

Details is the part of the /products/{id}/details API only. Every other field is returned from both /products and /products/{id}/details

linode-gh-bot · 2026-01-09T10:39:45Z

Cloud Manager UI test results

🔺 1 failing test on test run #7 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
`1 Failing`	`854 Passing`	`11 Skipped`	`40m 53s`

Details

Failing Tests
	Spec	Test
❌	`clone-linode.spec.ts`	Cloud Manager Cypress Tests→clone linode » can clone a Linode from Linode details page

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts"

pmakode-akamai

thanks @harsh-akamai for making the suggested changes - looks good to me. Could you check if we need to add a changeset for the new changes to the apiv4 package?

upcoming: [M3-9225] - Add API queries for MarketplaceV2

140aac1

harsh-akamai requested review from pmakode-akamai and tvijay-akamai January 8, 2026 04:06

harsh-akamai self-assigned this Jan 8, 2026

harsh-akamai added the Marketplace label Jan 8, 2026

github-project-automation bot added this to Cloud Manager Jan 8, 2026

github-project-automation bot moved this to Review in Cloud Manager Jan 8, 2026

harsh-akamai marked this pull request as ready for review January 8, 2026 04:06

harsh-akamai requested a review from a team as a code owner January 8, 2026 04:06

Added changeset: Add API queries for MarketplaceV2

1bbbcf1

pmakode-akamai reviewed Jan 8, 2026

View reviewed changes

tvijay-akamai reviewed Jan 8, 2026

View reviewed changes

packages/queries/src/marketplace/marketplace.ts Show resolved Hide resolved

tvijay-akamai reviewed Jan 8, 2026

View reviewed changes

packages/queries/src/marketplace/marketplace.ts Show resolved Hide resolved

tvijay-akamai reviewed Jan 8, 2026

View reviewed changes

harsh-akamai added 5 commits January 8, 2026 18:37

PR feedback

56d813e

Merge branch 'develop' into m3-9925-add-api-queries-to-marketplace

5e38907

fixed api url and factories

83185f4

Merge branch 'm3-9925-add-api-queries-to-marketplace' of https://gith…

68a6772

…ub.com/harsh-akamai/manager into m3-9925-add-api-queries-to-marketplace

added queries for /marketplace/types

ffaed0c

tvijay-akamai approved these changes Jan 9, 2026

View reviewed changes

tvijay-akamai added the Add'tl Approval Needed Waiting on another approval! label Jan 9, 2026

pmakode-akamai reviewed Jan 9, 2026

View reviewed changes

PR feedback @pmakode-akamai

c147bab

pmakode-akamai approved these changes Jan 9, 2026

View reviewed changes

github-project-automation bot moved this from Review to Approved in Cloud Manager Jan 9, 2026

tvijay-akamai removed the Add'tl Approval Needed Waiting on another approval! label Jan 9, 2026

tvijay-akamai merged commit 25a4879 into linode:develop Jan 9, 2026
34 of 35 checks passed

github-project-automation bot moved this from Approved to Merged in Cloud Manager Jan 9, 2026

		@@ -0,0 +1,197 @@
		import { APIError, createPartnerReferral, ResourcePage } from '@linode/api-v4';

	category: Factory.each((id) => `marketplace-category-${id}`),
	name: Factory.each((id) => `marketplace-category-${id}`),

	title_tag: 'Marketplace Product Title Tag',
	tile_tag: '60 days free trial',

	logo_url_dark_mode: 'https://www.example.com/logo-night-mode.png',
	logo_url_dark_mode: 'https://www.example.com/logo-dark-mode.png',

		@@ -1,42 +1,59 @@
		export interface MarketplaceProductDetail {
		documentation: string;

upcoming: [M3-9225] - Add API queries for MarketplaceV2 #13255

upcoming: [M3-9225] - Add API queries for MarketplaceV2 #13255

Uh oh!

Conversation

harsh-akamai commented Jan 8, 2026

Changes 🔄

Scope 🚢

How to test 🧪

Verification steps

As an Author, to speed up the review process, I considered 🤔

As an Author, before moving this PR from Draft to Open, I confirmed ✅

Uh oh!

pmakode-akamai left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tvijay-akamai commented Jan 8, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tvijay-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

linode-gh-bot commented Jan 9, 2026

Cloud Manager UI test results

🔺 1 failing test on test run #7 ↗︎

Details

Troubleshooting

Uh oh!

pmakode-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

pmakode-akamai left a comment •

edited

Loading